Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tm2): add sdk/params module #2920

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat(tm2): add sdk/params module #2920

wants to merge 3 commits into from
+1,039 −28

Conversation

moul
Copy link
Member

@moul moul commented Oct 7, 2024 •
edited
Loading

  • port x/params -> sdk/params b930513
  • inject in vmkeeper + add std.SetConfig 602245d
  • implement in gnoland 783a044
    • appchain
    • rpc query
    • txtar
  • implement or add comment where we should use it in the existing codebase
    • namespace's realm target
    • some gnovm configuration variables
    • some things that are currently misplaced in the appchain config/appstate or as gnoland start flags
  • Improve port
    • Consider creating a new dynamic keeper instead of adding new methods on the base one

@moul moul self-assigned this Oct 7, 2024
@moul moul marked this pull request as ready for review October 7, 2024 13:35
@moul moul requested review from a team, jaekwon, piux2 and zivkovicmilos as code owners October 7, 2024 13:35
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Oct 7, 2024
@moul moul marked this pull request as draft October 7, 2024 13:35
@codecov Codecov
Copy link

codecov bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 38.57143% with 172 lines in your changes missing coverage. Please review.

Project coverage is 60.88%. Comparing base (628f965) to head (783a044).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
gnovm/stdlibs/generated.go 0.00% 56 Missing ⚠️
tm2/pkg/sdk/params/handler.go 0.00% 35 Missing ⚠️
tm2/pkg/sdk/params/keeper.go 63.75% 19 Missing and 10 partials ⚠️
gnovm/stdlibs/std/params.go 0.00% 23 Missing ⚠️
tm2/pkg/sdk/params/table.go 44.44% 11 Missing and 4 partials ⚠️
gno.land/pkg/sdk/vm/builtins.go 57.14% 9 Missing ⚠️
gno.land/pkg/sdk/vm/keeper.go 57.14% 3 Missing ⚠️
tm2/pkg/sdk/auth/keeper.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2920      +/-   ##
==========================================
- Coverage   60.96%   60.88%   -0.09%     
==========================================
  Files         564      570       +6     
  Lines       75273    75548     +275     
==========================================
+ Hits        45893    45995     +102     
- Misses      26009    26170     +161     
- Partials     3371     3383      +12
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 67.87% <62.50%> (-0.06%) ⬇️
gnovm 65.58% <0.00%> (-0.20%) ⬇️
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (+0.35%) ⬆️
tm2 62.04% <52.07%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul moul force-pushed the dev/moul/mod-params branch 2 times, most recently from e31c026 to c177c69 Compare October 8, 2024 10:42
@Kouteki Kouteki mentioned this pull request Oct 8, 2024
Open
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Oct 9, 2024
@moul moul force-pushed the dev/moul/mod-params branch 4 times, most recently from df1da8c to 2a5b678 Compare October 10, 2024 18:07
@moul moul force-pushed the dev/moul/mod-params branch 2 times, most recently from 4c04221 to 95ab0bd Compare October 11, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaekwon jaekwon Awaiting requested review from jaekwon jaekwon is a code owner

@piux2 piux2 Awaiting requested review from piux2 piux2 is a code owner

@zivkovicmilos zivkovicmilos Awaiting requested review from zivkovicmilos zivkovicmilos is a code owner

@thehowl thehowl Awaiting requested review from thehowl thehowl will be requested when the pull request is marked ready for review thehowl is a code owner

@gfanton gfanton Awaiting requested review from gfanton gfanton will be requested when the pull request is marked ready for review gfanton is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@moul moul

Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
💪 Bounties & Worx
Status: No status
😎 Manfred's Board
Status: 🎯 Current Topics
🧙‍♂️gno.land core team
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@moul